QA Session Recordings

ComfyUI Frontend · Automated QA · Issue #10612 · main @ d946694 · QA @ 04bf4cb · CI Job · 2026-04-01T13:45:21Z → 2026-04-02 02:51 UTC
QA Badge
Issue #10612 reports
Promoted indicator inside parent subgraph is missing on nested subgraphs.
Title: Promoted indicator inside parent subgraph is missing on nested subgraphs. Description: ### Prerequisites - [x] I am running the latest version of ComfyUI
🐧LinuxReport
Pass 1
Pass 2
AI Comparative Review
# linux QA Video Report - Generated at: 2026-04-02T02:41:37.995Z - Model: `gemini-3-flash-preview` - Target: https://github.com/Comfy-Org/ComfyUI_frontend/issues/10612 - Source video: `./qa-artifacts/qa-report-Linux-23880532164/qa-session-1.mp4` - Video size: 46.3 MB ## AI Review ## Summary The reported bug (Issue #10612) involves the visual indicator for promoted widgets being missing from nested subgraphs and widgets losing their "promoted" status when packed into a new subgraph. The provided video **does not perform any of the reproduction steps**. After the initial login and briefly opening the templates menu, the recording shows a static, empty canvas for over 8 minutes. No nodes were created, no subgraphs were formed, and no widgets were promoted. ## Confirmed Issues No issues confirmed as no testing was performed in the video. ## Possible Issues (Needs Human Verification) - **Test Session Failure:** The recording shows an 8-minute session where no UI interactions occur after the first 10 seconds. This suggests the automated test script failed to execute or the environment became unresponsive. ## Overall Risk `LOW` (Based on this video, as no functionality was tested). ## Verdict INCONCLUSIVE {"verdict": "INCONCLUSIVE", "risk": null, "confidence": "high"} --- # linux QA Video Report - Generated at: 2026-04-02T02:46:52.005Z - Model: `gemini-3-flash-preview` - Target: https://github.com/Comfy-Org/ComfyUI_frontend/issues/10612 - Source video: `./qa-artifacts/qa-report-Linux-23880532164/qa-session-2.mp4` - Video size: 40.0 MB ## AI Review ## Phase 1: Blind Observation 1. **00:00 - 00:04**: The user logs in to the ComfyUI interface, selecting the user "qa-ci" and clicking "Next". 2. **00:05 - 00:15**: The workspace loads. A red error toast appears: "1 required model is missing" (Load Checkpoint). The user proceeds to select a group of nodes including "Load Checkpoint", "CLIP Text Encode", "KSampler", "Empty Latent Image", and "VAE Decode". 3. **00:16**: The user right-clicks the selection and chooses **"Convert Selection to Subgraph"**. 4. **00:17 - 00:19**: A new node titled "Subgraph" is created. It contains the previously selected nodes. 5. **00:20 - 00:22**: The user clicks the **edit (pencil) icon** on the Subgraph node to enter its internal view. 6. **00:23 - 00:42**: Inside the subgraph, the user right-clicks various widgets and selects **"Promote to Subgraph"**: * `ckpt_name` on "Load Checkpoint". * `steps`, `cfg`, `sampler_name`, `scheduler`, and `denoise` on "KSampler". * Visual indicators (small purple circles/dots) appear next to these widget names inside the nodes. 7. **00:43 - 00:45**: The user returns to the main graph. The Subgraph node now displays the 6 promoted widgets on its face. 8. **00:48 - 00:52**: The user selects the Subgraph node, right-clicks, and selects **"Convert Selection to Subgraph"** again. This creates a nested structure. 9. **00:53 - 00:56**: The user clicks the edit icon on the new parent Subgraph node. 10. **00:57 - 00:59**: **BEFORE state**: The inner Subgraph node (the one created in step 3) had 6 widgets. **AFTER state**: Inside the parent subgraph, the inner Subgraph node is visible but it has **ZERO** widgets. All previous promotions are gone. 11. **01:03 - 01:10**: The user enters the nested (child) subgraph and re-promotes the `ckpt_name` widget. 12. **01:11 - 01:12**: The user returns to the parent subgraph. The child Subgraph node now shows the `ckpt_name` widget. **Observation**: There is no visual indicator (purple dot) next to the widget name on the child Subgraph node. 13. **01:15**: The user right-clicks the `ckpt_name` widget on the child Subgraph node and selects **"Promote to Subgraph"** (promoting it to the parent). 14. **01:23 - 01:25**: On the main graph, the parent Subgraph node now shows `ckpt_name`. 15. **01:26 - 01:41**: The user drills back down into the child subgraph and promotes several more widgets (`steps`, `cfg`, etc.). 16. **01:42**: Inside the parent subgraph, the child Subgraph node now shows all the promoted widgets. **Observation**: None of these widgets have the visual "promoted" indicator icon next to them. 17. **01:58 - 02:00**: Close-up of the child Subgraph node inside the parent subgraph: The widgets are listed, but the space to the left of the labels is empty (no indicator icons). 18. **02:03**: The user enters the child subgraph. The original nodes (e.g., Load Checkpoint) **do** have the purple indicators next to their promoted widgets. ## Phase 2: Compare against expected behavior ### Issue #10612 The issue reports that visual indicators for promoted widgets are missing on nested subgraphs and that subgraphs lose their promoted widgets when packed into a new subgraph. 1. **Did the video perform the reproduction steps?** * Yes. A subgraph was created with promoted widgets (Steps 1-7). * It was packed into another subgraph (Step 8). * Widgets were promoted from the nested subgraph (Steps 11-16). 2. **Did Phase 1 observations show the reported bug behavior?** * **Confirmed**: At 00:58, the child subgraph lost all its promoted widgets immediately after being packed into a parent subgraph ("Convert Selection to Subgraph"). * **Confirmed**: At 01:12, 01:42, and 01:58, the widgets displayed on the child Subgraph node (inside the parent subgraph) are missing the purple promoted indicator icons, even though they have been promoted. ## Summary The video clearly reproduces both aspects of the reported bug. First, subgraphs lose all existing widget promotions when they are nested using the "Convert Selection to Subgraph" feature. Second, when widgets are manually re-promoted within a nested subgraph, the nested Subgraph node itself fails to display the visual "promoted" indicator icons that signify a widget is linked to its parent subgraph. ## Confirmed Issues ### Subgraph loses promoted widgets upon nesting `HIGH` `00:56` `Confidence: High` When a subgraph that already has promoted widgets is selected and converted into a new subgraph (nesting), all existing widget promotions on the inner subgraph are cleared. **Evidence:** At 00:44, the subgraph node clearly shows 6 widgets. After converting this node into a new subgraph and viewing it at 00:56, the node is empty of all widgets. **Suggested Fix:** Ensure the "Convert Selection to Subgraph" logic preserves existing `widgets_values` and promotion metadata for nodes within the selection. ### Missing promoted indicator on nested Subgraph nodes `MEDIUM` `01:58` `Confidence: High` Widgets on a Subgraph node that have been promoted to a parent subgraph do not display the purple visual indicator icon. This makes it impossible to tell at a glance which widgets are promoted versus local when looking at a nested subgraph node. **Evidence:** At 01:58, the child Subgraph node has several widgets, but none show the purple dot indicator. In contrast, at 02:03, the standard nodes inside that same child subgraph correctly display the indicators. **Suggested Fix:** The Subgraph node component should check for promoted status on its own internal widgets and render the indicator icon accordingly, similar to standard nodes. --- ## Overall Risk The risk is **medium-to-high** for users who rely on complex, modular workflows. The loss of promotions upon nesting forces tedious manual rework, and the lack of visual indicators degrades the usability of the subgraph system by hiding the state of the graph. ## Verdict {"verdict": "REPRODUCED", "risk": "medium", "confidence": "high"}